Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multichar alleles #88

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

benjeffery
Copy link
Member

The GeL trees currently cannot load the mutations page as it enforces single-char alleles. This change will slow things down a little - hopefully that won't be too bad. Will test and report back before we merge.

@jeromekelleher
Copy link
Member

I don't think we're actually using the states at the moment, so we could just comment out/remove for now.

@benjeffery
Copy link
Member Author

Just measured and commenting out the code only saves a few seconds off 120 seconds, so might as well leave it in.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromekelleher jeromekelleher merged commit 3814852 into tskit-dev:main Sep 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants